Project

General

Profile

Bug #25003

Bug in geo::OpDetGeo isBar() when using sphere/semi-sphere optical detectors

Added by Patrick Green about 1 month ago. Updated 15 days ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
-
Start date:
09/23/2020
Due date:
% Done:

100%

Estimated time:
Occurs In:
Experiment:
-
Co-Assignees:
Duration:

Description

The isBar() function is geo::OpDetGeo incorrectly returns true when the the optical detector is a TGeoSphere object. I believe this is because the TGeoSphere object inherits from TGeoBBox, and the isBar() function checks whether the object is a box.

It would be useful to also have an "isSphere()" function analogous to isBar() and isTube() for use with spherical optical detectors - e.g. dynamic_cast<TGeoSphere const*>(opDet.Shape()) != nullptr. This is required by the semi-analytic / parameterised light simulation in SBND (and any other detectors using PMTs).

History

#1 Updated by Kyle Knoepfel 29 days ago

  • Assignee set to Kyle Knoepfel
  • Status changed from New to Assigned

#2 Updated by Gianluca Petrillo 24 days ago

A proposed solution is offered with larcorealg pull request #11.

#3 Updated by Kyle Knoepfel 22 days ago

  • Assignee changed from Kyle Knoepfel to Gianluca Petrillo

#4 Updated by Kyle Knoepfel 15 days ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

The fix was included in LArSoft v9_06_00.



Also available in: Atom PDF