Project

General

Profile

Bug #24970

DataSenderManager in BoardReader is constructed after data flow has already started

Added by Eric Flumerfelt about 1 month ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Category:
Known Issues
Target version:
Start date:
09/14/2020
Due date:
% Done:

0%

Estimated time:
Experiment:
ICARUS, SBND
Co-Assignees:
Duration:

Description

Currently, the order of operations in BoardReaderApp::do_start is incorrect in that it follows "data flow" order, when it should instead be in the reverse of that order so that subsequent pieces of the system are ready to receive data when that data is available.

Several checks should be added to enforce the strict order of this transition:
  • CommandableFragmentGenerator::getNext should wait/return early until CFG::StartCmd has completed
  • After starting the BoardReaderCore receive_fragments and send_fragments threads, BoardReaderApp::do_start should wait for those threads to raise "ready" flags before calling CFG::StartCmd

History

#1 Updated by Eric Flumerfelt about 1 month ago

Fix implemented on artdaq:bugfix/24970_BoardReader_startOrdering

#2 Updated by Gennadiy Lukhanin 12 days ago

  • Status changed from New to Resolved

Marking as resolved, so the reviewed status becomes available.

#3 Updated by Gennadiy Lukhanin 12 days ago

  • Status changed from Resolved to Reviewed

This branch was merged into the for_sbndaq-artdaq branch and several test runs were taken during new release tests for artdaq v3_09_01 and sbndaq v0_07_01. I looked at code changes, ran artdaq tests (mrb t), and ran artdaq demo on evb05 in the /scratch/artdaqdemo directory.

#4 Updated by Eric Flumerfelt 4 days ago

  • Target version set to artdaq v3_09_02
  • Status changed from Reviewed to Closed


Also available in: Atom PDF