Project

General

Profile

Bug #24858

Boardreader selection list

Added by Gennadiy Lukhanin 5 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Urgent
Start date:
08/26/2020
Due date:
% Done:

100%

Estimated time:
Occurs In:
Co-Assignees:
Duration:

Description

The boardreader selection list shows duplicate entries if the database is enabled. Please note we need to preserve the same order as in the known_boardreaders_list file, and the list box control should not be sorting anything.


Related issues

Blocks ArtDaq RunControl GUI - Milestone #25316: v1_02_00Resolved12/14/2020

History

#1 Updated by Iker de Icaza Astiz 5 months ago

  • Priority changed from Normal to Urgent

It's important we tackle this first.

#2 Updated by Iker de Icaza Astiz 3 months ago

To use database features we need to uncomment a line on user_sourcefile

######################################################    
##Uncomment  the line below to enable artdaq_database.
#export DAQINTERFACE_FHICL_DIRECTORY=IGNORED
######################################################

#3 Updated by Esteban Cristaldo about 2 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

This issue was caused when the RC compared the known_components_list compoenent name with the asociated component .fcl that had the same name plus an extention before '.fcl'

e.g.
from know_component_list: icarustpcew05
from the DB: icarustpcew05.fcl icarustpcew05n1.fcl icarustpcew05n2.fcl
The RC GUI filled 3 times the listview with icarustpcew05

This issue is resolved.

Furthermore, it was decided that the RC GUI should not make this comparison given that the DB does not store a list of components. So, for now the GUI lists the know_components_list when selecting a configuration from the database.

#4 Updated by Esteban Cristaldo about 2 months ago

  • Status changed from Resolved to Under Discussion

#5 Updated by Iker de Icaza Astiz about 2 months ago

  • Status changed from Under Discussion to Closed

Esteban and myself tested this on ICARUS Control Room.

The new release v1_01_03 has this fix.

Closing.

#6 Updated by Iker de Icaza Astiz about 1 month ago

We ended up reverting to the old way: comparing components from the DB to those of known_boardreader_list, fixing the previous faulty logic of course.

All commits are in branch bugfix/duplicated_db_components which I'll now merge to develop.

The last batch is:

a60b92c 2020-12-03 Gennadiy Sort the components list box
ab2f078 2020-12-11 Iker Loïc de Ic.. Remove old comment, mark a potential improvement
2f120e9 2020-12-01 ecristal All components are selected in components listview selection model
d31bea9 2020-12-01 ecristal clean up. Added 'break' when a component is found in the .fcl directory
a52c2eb 2020-12-01 ecristal GUI returns to previous behaviour when selecting a configuration from the database. It lists the components that are found in the know_components_list and in the DB configuration

This issue will remain closed.

#7 Updated by Iker de Icaza Astiz about 1 month ago

Also available in: Atom PDF