Trigger TPC offset incorrectly reported by DetectorClocksStandard
The usage pattern:
auto const detClocks = art::ServiceHandle<detinfo::DetectorClocksService>()->DataForJob(); std::cout << detClocks.TriggerOffsetTPC() << std::endl;
seems to return the wrong value.
#3 Updated by Gianluca Petrillo 6 months ago
- Priority changed from High to Normal
Resolution in lardataalg pull request #8.
Two initialisers got swapped, clearly the trigger TPC offset and the TPC frame clock.
Three comments on that.
First, that assignment holds until
DetectorClocksServiceStandard::preBeginRun() is called. This probably means that only initialisations at
beginJob() level and non-art initialisations will be affected. For example, I have discovered the issue while figuring out how to properly update gallery@Python code.
So it turns out to be less dramatic than I had thought (probably enough to bust TITUS event display).
Second, I have added back some debugging output method. It has proven to be useful in many occasions in the past, and today would have been as well — it was, in fact, after I restored it. I enabled that output back in the unit test, even if it is effectively a non-automatic test.
If that is against some policy, the test code can be replicated into an utility.
Last, the initialisation code coming with
v09_00_00 version of
DetectorClocksStandard is more fragile than the previous one: this bug could not have occurred with that older initialisation pattern. I suggest to consider the adoption of a pattern similar to that one, or a different configuration storage, to avoid future issues.