Bug #2473: No error when services present in two places in .fcl - art - Fermilab Redmine

Bug #2473

No error when services present in two places in .fcl

Added by Rob Kutschke almost 9 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Christopher Green

Category:

Infrastructure

Target version:

1.13.00

Start date:

02/09/2012

Due date:

% Done:

100%

Estimated time:

Occurs In:

Scope:

Internal

Experiment:

Mu2e

SSI Package:

art

Duration:

Description

The following fhicl fragment without error.

services : {
RandomNumberGenerator : { }
user : {
RandomNumberGenerator : { }
}
}

I would like this to be an error that stops the program. The present example is not a big deal but this could be a problem if the two instances were configured differently; in such a case it could be very perplexing if a user modifies the parameter set and nothing changes ( because art decided to use the other, unchanged, parameer set).

Associated revisions

Revision fd9f1057 (diff)
Added by Christopher Green about 6 years ago

Implement issue #2473.

History

#1 Updated by Marc Paterno over 8 years ago

Status changed from New to Accepted

We need to determine the current behavior of art when confronted by this configuration.

Making this configuration be illegal would mean that it is no longer possible for an experiment to define a service with the same name as one supplied with art. This makes the 'user' block in the configuration file be less useful; it becomes only documentation to the experimenter that a specific service has been supplied by the experiment, rather than by art.

#2 Updated by Christopher Green over 7 years ago

Status changed from Accepted to Feedback
Target version set to 1.09.00
Scope set to Internal
Experiment Mu2e added
SSI Package art added

It is already the case that the flexibility supposed to be enabled by having two different areas for service, "ours" vs "yours", is already not available because we cannot resolve two services of the same name but defined in different directories in the same way as we can for modules (the service library name is taken from the parameter name here, and parameter names cannot contain slashes).

We propose to eliminate the user clause of services by combining the two spaces. We will continue to honor user for a while, but it will be an error to specify the same service in both places (as of right now, I'm not sure which configuration would, "win."