Project

General

Profile

Bug #24344

non python-3 compatible code in jobsub_submit and jobsub_submit_dag

Added by Dennis Box 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
04/23/2020
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

line 310 of jobsub_submit and line 180 of jobsub_submit_dag reads:

for key, value in vars(options).iteritems()

Sadly, iteritems() has been taken out of the dictionary class in python3.
I commented out the offending lines in both commands for rc1, but I am unsure if this breaks anything besides the debug statetment the method is used in.

(Higher priority):
Does commenting the lines out break #21031? I do not think so but wanted to be sure.
(Lower priority if answer to above question is 'no')
Can you re-implement this in a more portable way?

History

#1 Updated by Shreyas Bhat 2 months ago

  • Status changed from New to Feedback

Done by changing iteritems() to items(). This makes the call negligibly more inefficient in python2, but it is the standard way to do it in python3.

#2 Updated by Shreyas Bhat 2 months ago

  • Assignee changed from Shreyas Bhat to Dennis Box

Dennis, would you please take a look at branch 24344 to check the changes? It should only be one line each in jobsub_submit and jobsub_submit_dag.

#3 Updated by Dennis Box about 2 months ago

  • Status changed from Feedback to Resolved

merged to master



Also available in: Atom PDF