Project

General

Profile

Bug #24340

When generated xyzConfig.cmake files do find_package, you can get recursively duplicated -I paths, etc.

Added by Marc Mengel 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
04/23/2020
Due date:
% Done:

0%

Estimated time:
Duration:

Description

So for example when building icaruscode, we were getting a command line too long error on the compiles, because we had cetlib-except's -I flag 638 times, hep-concurrency 541 times, cetlib's 319 times, etc.
and cmake was for example finding Boost 397 times...

The solution is to include-guard the xyzConfig.cmake files; which Patrick was already doing by hand
after the fact with an if-style include guard; but it turns out cmake provides an include_guard()
macro.

I've made a feature/include_guards branch which does this; I think you can just roll it in.

History

#1 Updated by Kyle Knoepfel 2 months ago

  • Assignee set to Christopher Green
  • Status changed from New to Assigned

#2 Updated by Marc Mengel 2 months ago

  • Assignee changed from Christopher Green to Marc Mengel
  • Status changed from Assigned to Resolved

Fixed by merging feature branch, 96cea96ce9b



Also available in: Atom PDF