Bug #21031: jobsub_submit allows more than one --group argument
Review request [commit:c56de182a5c7a2f3cbdb6d6de5d254b1fddeb434: Added iteritems() to vars call]
I think I've fixed all the underlying issues. Please review this branch/commit and let me know if everything looks good.
You generally run a new release through the test suite, right?
#1 Updated by Dennis Box 4 months ago
- Assignee changed from Dennis Box to Shreyas Bhat
- Status changed from New to Accepted
The code changes look reasonable, and I tested them a bit. I confirm that they seem to work for --group or -G for jobsub_submit and jobsub_submit_dag. I notice they do not work for other commands, I don't know that this is a high priority.
Please merge this change into master. We should discuss adding some tests to the test suite tomorrow after the jobsub meeting.
#2 Updated by Shreyas Bhat 4 months ago
That's a good point. I purposefully only changed jobsub_submit and jobsub_submit_dag, but perhaps this should be a changed for all commands, since they all require the -G flag. Would you like me to do that this release or next one?
On that note, perhaps we should consider making a parser for the jobsub client that all the commands can inherit and then build on top of. What are your thoughts on that? I could slate that for next release, but it shouldn't be difficult once we know the flags that are common among all the commands.