Necessary Maintenance #24069
Non-standard SpaceCharge interface
Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
Simulation
Target version:
-
Start date:
02/19/2020
Due date:
% Done:
0%
Estimated time:
Experiment:
-
Description
Recent modifications of spacecharge::SpaceCharge interface introduced a second argument in the methods:
virtual geo::Vector_t GetCalPosOffsets(geo::Point_t const& point, int const& TPCid) const = 0;
virtual geo::Vector_t GetCalEfieldOffsets(geo::Point_t const& point, int const& TPCid) const = 0;The offset is returned depending on which TPC is specified. The TPC is specified by a plain number.
LArSoft standard is to specify that by `geo::TPCID`. The interface should be updated accordingly.
Note that in principle if GeometryCore is available to the service, the TPC ID is not required as it should be possible to find out which TPC the point is in. Optimisation reasons may still lead to prefer a more explicit interface.
History
#1 Updated by Gianluca Petrillo about 1 month ago
- Description updated (diff)
#2 Updated by Gianluca Petrillo about 1 month ago
- Description updated (diff)
#3 Updated by Kyle Knoepfel about 1 month ago
- Status changed from New to Feedback
Sounds like a reasonable change to make. Are you willing to do it?
#4 Updated by Kyle Knoepfel about 1 month ago
Gianluca, are you able to make the change and create feature branches for the experiments?