Project

General

Profile

Bug #23816

Random Number Generator not Seeded in GenieHelper tool

Added by Gray Putnam 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Start date:
12/30/2019
Due date:
% Done:

0%

Estimated time:
Duration:

Description

The random number generator in the class in nugen responsible for emulating the FNAL beam spill timing is not seeded. This means that all neutrino generation times in a set of MC files will be identical.

The base class implementing the timing is here (nugen:source:nugen/EventGeneratorBase/GENIE/EvtTimeShiftI.cxx#L18) -- the un-seeded random generator is constructed at line 18.

The instance of this virtual class that specializes to the FNAL beam timing is here (nugen:source:nugen/EventGeneratorBase/GENIE/EvtTimeFNALBeam.cxx). It uses the default constructed random number generator and does not update it to be a seeded one.

History

#1 Updated by Gianluca Petrillo 9 months ago

  • Description updated (diff)

That is all true (TRandom3 is initialised with seed 4357 by default).
Just a reminder that all this machinery is broken anyway because it ignores the correlation between the time of the interaction and the distance of the interaction from the target.

Also available in: Atom PDF