Project

General

Profile

Feature #23815

Add MergeSimSources Back into larsim

Added by Gray Putnam 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/30/2019
Due date:
% Done:

100%

Estimated time:
4.00 h
Spent time:
Experiment:
SBND
Co-Assignees:
Duration:

Description

Earlier this year, the MergeSimSources module in larsim was removed as it was no longer being used.

This module is now needed to generate MC in SBND and ICARUS. We would like to have this module added back in.

There is a feature branch of larsim (feature/gputnam-MergeSimSources) that has this module restored. This branch also includes a fix for a bug in the previous MergeSimSources module (AuxDetSimChannels were not merged correctly). Please let me know if you would like me to make any changes to this branch before merging it into larsim.

History

#1 Updated by Kyle Knoepfel 7 months ago

  • Status changed from New to Feedback

This request is reasonable. Can you please run the CI tests to ensure that it works as expected? If there are no problems, the feature branch will be accepted for this week's release.

#2 Updated by Gray Putnam 7 months ago

Kyle Knoepfel wrote:

This request is reasonable. Can you please run the CI tests to ensure that it works as expected? If there are no problems, the feature branch will be accepted for this week's release.

Just submitted the CI tests!

#3 Updated by Lynn Garren 7 months ago

  • Estimated time set to 4.00 h
  • Assignee set to Lynn Garren
  • Status changed from Feedback to Assigned

Found the CI results. It all looks good.

#4 Updated by Lynn Garren 7 months ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Resolved

This is part of larsoft v08_39_00.

#5 Updated by Lynn Garren 6 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF