Project

General

Profile

Necessary Maintenance #23781

ssl_verifyhost=False not needed in changeJobState() in client

Added by Dennis Box 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
12/18/2019
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

jobsub_rm, hold, and release call client function changeJobState() with the parameter ssl_verifyhost=False.
This was needed in the days when fifebatch.fnal.gov was a round-robin dns alias for jobsub01 and 02.

Now that fifebatch.fnal.gov is a Ha_proxy server, and more importantly, now that the name chaining in the hostcerts for jobsub0x to fifebatch is done properly, this is not needed.

Moreover, partial porting from pycurl to the requests library with ssl_verifyhost=false results in the client repeatedly complaining:

Removing job with jobid=
/usr/lib/python2.6/site-packages/urllib3/connectionpool.py:769: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
InsecureRequestWarning)

History

#1 Updated by Dennis Box 5 months ago

  • Tracker changed from Bug to Necessary Maintenance

#2 Updated by Dennis Box 5 months ago

  • Assignee changed from Dennis Box to Shreyas Bhat
  • Status changed from New to Feedback

the change in branch 23781 tested OK for me but please give it a quick review

#3 Updated by Shreyas Bhat 5 months ago

  • Assignee changed from Shreyas Bhat to Dennis Box
  • Status changed from Feedback to Accepted

That looks good. I tested with jobsub_submit, hold, release, and rm.

#4 Updated by Dennis Box about 2 months ago

  • Status changed from Accepted to Feedback

#5 Updated by Dennis Box about 2 months ago

  • Status changed from Feedback to Closed


Also available in: Atom PDF