Project

General

Profile

Bug #23770

jobsub_prio still uses optparse

Added by Shreyas Bhat 6 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JobSub Client
Target version:
Start date:
12/20/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

With jobsub 1.3, all server and client libraries were transitioned from optparse to argparse.

Except for jobsub_prio. We somehow missed that. Transition that over, and while we're doing this, remove all the commented-out optparse code from the client and server.


Subtasks

Bug #23790: Review request [commit:aa004f70c75fab93f5c23342880d2f7f8935c491: Removed commented optparse calls]ClosedDennis Box

History

#1 Updated by Shreyas Bhat 6 months ago

In addition to this, there was a bug introduced in commit 6da965bd where we commented out the option for a uid. The call to jobsubClient.adjust_prio expects a uid to be provided (previously the default was None). We should change line 183 so that for now, we don't provide a UID, so that call would be:

http_code = js_client.adjust_prio(jobid=jid, uid=None)

That will fix the bug Alex saw.

#2 Updated by Shreyas Bhat 6 months ago

Changes made. Will test tomorrow.

#3 Updated by Shreyas Bhat 5 months ago

  • Status changed from New to Feedback

Review request sent to Dennis.

#4 Updated by Shreyas Bhat 5 months ago

  • Start date changed from 12/16/2019 to 12/20/2019
  • Due date set to 12/20/2019

due to changes in a related task: #23790

#5 Updated by Shreyas Bhat 5 months ago

  • Status changed from Feedback to Resolved

Merged to master after passing code review.

#6 Updated by Dennis Box 5 months ago

  • Target version changed from v1.3.2 to v1.3.1

#7 Updated by Dennis Box about 2 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF