Project

General

Profile

Bug #23671

PdspNoiseRemoval crashes with long time windows

Added by David Adams 11 months ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
12/01/2019
Due date:
% Done:

0%

Estimated time:
Duration:

Description

I get a crash in PdspNoiseRemoval tool when I run on 7.5 ms (15k tick) data. The message was a memory error in PdspNoiseRemovval. By setting MALLOC_CHECK_ to 2, I was able to get a crash and a line number: 150 in PdspNoiseRemoval_tool.cc.

The problem is that the tool uses the LArFFT service which has a default size of 8192.

History

#1 Updated by David Adams 11 months ago

I have modified the tool to add a check and log messages and abort if the the FFT size is inadequate.

#2 Updated by Tingjun Yang 11 months ago

If the metadata has the correct readout time of 7.5 ms, the detector properties service and larfft service should set the correct readout window and larfft size. Which file are you testing this on?

#3 Updated by David Adams 11 months ago

This is run 6509 which has the correct readout time if I grep readout_window in samweb get-metadata.

Maybe my configuration is missing the magic that communicates this to LArFFT?

#5 Updated by David Adams 11 months ago

Too large a readout window (more than twice the data size) can also cause problems in PdspNoiseRemoval (#23767). Protection against that has also been added.

#6 Updated by David Adams 7 days ago

  • Status changed from New to Closed

I believe this is resolved.



Also available in: Atom PDF