Project

General

Profile

Feature #2359

Add Frontend START expression in the match section

Added by Igor Sfiligoi almost 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Igor Sfiligoi
Category:
Frontend
Target version:
Start date:
01/06/2012
Due date:
% Done:

90%

Estimated time:
Spent time:
Stakeholders:
Duration:

Description

Hi all.

Every time I configure a frontend, I tie the Frontend match expression with the START expression;
it is the only way to make sure we do not end up with glideins that do not match any jobs.

Right now, I have to specify the two in two different places, once in the match section and once in the attributes section,
which are far apart and there is no obvious relation between them.
(not to mention having to define a GLIDECLIENT_Group_Start attribute to be sort of nerdy)

I think it would be better if we defined both in the match section, since they are both effectively used for matchmaking.
BTW: If the user decides to also define GLIDECLIENT_Group_Start attribute, we could just append to it.

Here is how it looks now:

  <match match_expr='(job.has_key("DESIRED_Sites") and (glidein["attrs"]["GLIDEIN_Site"] in job["DESIRED_Sites"].split(",")))'>
    ...
  </match>
  ...
  <attrs>
    ...
      <attr name="GLIDECLIENT_Group_Start" glidein_publish="False" job_publish="False" parameter="True" type="string" 
                     value='(stringListMember(GLIDEIN_Site,DESIRED_Sites,",")=?=True)'/>
    ...
  </attrs>

and here is how it would look like in my proposal:

  <match match_expr='(job.has_key("DESIRED_Sites") and (glidein["attrs"]["GLIDEIN_Site"] in job["DESIRED_Sites"].split(",")))'
         start_expr='(stringListMember(GLIDEIN_Site,DESIRED_Sites,",")=?=True)'>
   ...
  </match>

What do you think?

I am willing to implement it, if you guys agree it is a good idea,

Igor

BTW: I know it is annoying to have them in two different languages, too, and would love if one did not have to do that.
But that is too hard of a nut to grind for me.

History

#1 Updated by Igor Sfiligoi almost 8 years ago

  • Status changed from New to Assigned

#2 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from v2_5_5 to v2_5_6

#3 Updated by Igor Sfiligoi over 7 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Implemented.

Committed as
branch_v2plus 5218684ca19e7972452daedec7087cea886458c0
master d31e6e3f9fd7ec8bb163dc339656c6ce05eaa0be

Changed also the installers, to properly create the initial template file.
However, would be nice if the installer actually asked for the start expression (right now I just default to True)

#4 Updated by Igor Sfiligoi over 7 years ago

  • % Done changed from 100 to 90

Forgot:
I have not touched the documentation...

Can someone else please do that?

#5 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from v2_5_6 to v2_5_7

#6 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from v2_5_7 to v2_7_x

#7 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from v2_7_x to v2_6

#8 Updated by Parag Mhashilkar over 4 years ago

  • Status changed from Resolved to Closed

closing old resolved issue



Also available in: Atom PDF