Report inter-process communication network interfaces
In debugging a recent multicast problem at protoDUNE, and in debugging the changes that we have made to the configuration of multicast network interfaces in artdaq and DAQInterface, it would have been helpful to be able to easily see which network interfaces were being used by the underlying artdaq code in various scenarios.
This Issue requests that such reporting be added to the artdaq code. Ideally, this reporting would be at the TLVL_INFO level so that it can be found in the artdaq process log files, as well as in the TRACE buffer.
Added TRACEs of the network interfaces that are used in inter-process communications like table updates, data requests, and token reporting. (Issue #23362)
#2 Updated by Kurt Biery 9 months ago
For better or worse, there have been two substantive changes that have come up as part of making these changes and testing them:
There was an empty line in RoutingMasterCore (https://cdcvs.fnal.gov/redmine/projects/artdaq/repository/revisions/develop/entry/artdaq/Application/RoutingMasterCore.cc#L367) that seemed to be missing an "exit(1)", so I added that. We should talk about whether that is the right option.
It is helpful to have the ResolveHost call in RoutingMasterCore actually be a call to GetInterfaceForNetwork so that we can use subnet addresses for RoutingMaster.fcl/routing_master_hostname.
#4 Updated by Eric Flumerfelt 9 months ago
- Co-Assignees Eric Flumerfelt added
Code review & testing complete. I found a minor issue with RequestSender when 0.0.0.0 is passed as the multicast_out_address. When calling gethostname, it did not actually resize the string properly, leading to everything past the first 7 characters of the hostname to be truncated. Once this change has been independently verified, this issue can be considered reviewed.
#5 Updated by Kurt Biery 9 months ago
- Status changed from Resolved to Reviewed
- Co-Assignees Kurt Biery added
I have verified the fix to the gethostname call in RequestSender by running an artdaq-demo system with, and without, the fix on mu2edaq01.
I'm marking this Issue Reviewed, and I will merge the branch into develop. (and update the 'artdaq branches' page)