Project

General

Profile

Bug #23354

GUI Editor allows adding null-string-named stages...

Added by Marc Mengel over 1 year ago. Updated over 1 year ago.

Status:
Assigned
Priority:
Normal
Assignee:
Marc Mengel
Target version:
v4_2_0
Start date:
09/30/2019
Due date:
% Done:

100%

Estimated time:
First Occurred:
Scope:
Internal
Experiment:
-
Stakeholders:
Duration:

Description

If you go into the gui editor, click edit, add stage, click on a spot, then
just hit "OK", it will add a stage with no name. Saving same leads to ugliness.

According to Inspect in Chrome, the popup is id "node-popUp"...

https://cdcvs.fnal.gov/redmine/projects/prod_mgmt_db/repository/revisions/develop/entry/webservice/static/js/gui_editor_3.js#L1470

action goes to saveNodeData

https://cdcvs.fnal.gov/redmine/projects/prod_mgmt_db/repository/revisions/develop/entry/webservice/static/js/gui_editor_3.js#L1503

which sure enough, never checks for label being blank...

Associated revisions

Revision 183837f3 (diff)
Added by Marc Mengel over 1 year ago

fix for issue #23354

History

#1 Updated by Marc Mengel over 1 year ago

  • % Done changed from 0 to 100
  • Target version set to v4_2_0
  • Assignee set to Marc Mengel
  • Status changed from New to Resolved

Changed to highlight name field in red if OK is pressed without filling in a name, and not save an empty named stage.

#2 Updated by Kevin Retzke over 1 year ago

  • Status changed from Resolved to Assigned

This reared its head again

Leah Rieger 10:00 AM
Hi. I have a campaign stage that has no name and i cannot delete it. I’ve tried to add a name to it and delete it from the gui but it’s not working…can you help or let me know how i can take care of this if it happens in the future?

https://pomsgpvm01.fnal.gov/poms/show_campaign_stages/gm2/production?campaign_name=run_v9_32_00_Production&view_active=view_active&view_mine=1675&view_others=1675&view_production=view_production&update_view=update_view

#3 Updated by Marc Mengel over 1 year ago

This was an item created before the bugfix.
Cleaning them out is tedious..

Also available in: Atom PDF