Project

General

Profile

Feature #22680

Buffer utilitzation metrics for CommandableFragmentGenerator

Added by Eric Flumerfelt 6 months ago. Updated 25 days ago.

Status:
Reviewed
Priority:
Normal
Category:
-
Target version:
-
Start date:
06/04/2019
Due date:
% Done:

100%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

CommandableFragmentGenerator should have metrics analogous to those in SharedMemoryEventManager which report the current utilization of buffer space. Since CFG's buffer can be measured in both Fragments and Bytes, both should be reported alongside a single metric which reports which one is closer to full.

History

#1 Updated by Eric Flumerfelt 6 months ago

  • Assignee set to Eric Flumerfelt
  • Status changed from New to Assigned

Initial implementation on artdaq:feature/22680_CFG_BufferUsageMetrics.

#2 Updated by John Freeman 25 days ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Reviewed

I've confirmed that the expected metrics get published. Take run 3006 which used the head of the feature branch (mu2edaq01:/home/jcfree/run_records/3006). If I grep on one of the metric files from run 3006:

grep "Fragment Generator Buffer Full" ~jcfree/daqlogs/metrics/boardreader/br_13446_metrics.log

then I see the expected metrics.

One small quibble about the code. After I merged develop into feature/22680_CFG_BufferUsageMetrics (commit 03c17d007c9bb5105f8f769650db67a8dc57d62a) I noticed that one line that was different from develop was the following:


-               metricMan->sendMetric("Last Timestamp", timestamp, "Ticks", 1,
-                                     MetricMode::LastPoint, app_name);
+               metricMan->sendMetric("Last Timestamp", timestamp, "Ticks", 1, MetricMode::LastPoint);

...and I'm not sure if this is what we want.



Also available in: Atom PDF