Change internal representation of sim::OnePhoton
sim::OnePhoton is part of one of the two supported representation of scintillation light in LArSoft.
It is in fact part of the most expensive one, where each scintillation photon is saved individually as an element of a
Given that this is so expensive, it may be good to refresh and compact it.
The actions I propose are:
- replacement of
geo::Point_tin the two vector members
- move of the
booldata member at the end of the object
A survey in the code shows that the fixes after the first change are trivial.
Other actions that should take place at the same time:
- ordering operator (ordering by increasing
Time, then by
InitialPosition(x, y, z) and
FinalLocalPosition(x, y, z)
- transformation into
- removal of the empty constructor and explicit initialization of the data members