Project

General

Profile

Feature #22628

Change internal representation of sim::OnePhoton

Added by Gianluca Petrillo 4 months ago. Updated 4 months ago.

Status:
Assigned
Priority:
Normal
Category:
Data products
Target version:
-
Start date:
05/23/2019
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

sim::OnePhoton is part of one of the two supported representation of scintillation light in LArSoft.
It is in fact part of the most expensive one, where each scintillation photon is saved individually as an element of a sim::SimPhotons collection.

Given that this is so expensive, it may be good to refresh and compact it.
The actions I propose are:

  1. replacement of TVector3 with geo::Point_t in the two vector members
  2. move of the bool data member at the end of the object

A survey in the code shows that the fixes after the first change are trivial.

Other actions that should take place at the same time:

  1. ordering operator (ordering by increasing Time, then by MotherTrackID, InitialPosition (x, y, z) and FinalLocalPosition (x, y, z)
  2. transformation into struct
  3. removal of the empty constructor and explicit initialization of the data members

History

#1 Updated by Kyle Knoepfel 4 months ago

  • Assignee set to Gianluca Petrillo
  • Status changed from New to Assigned

The proposal sounds sensible. Please proceed, place any code changes on feature branches, and plan to present at a LArSoft coordination meeting.



Also available in: Atom PDF