Project

General

Profile

Bug #22542

incorrect exception handling glideinFrontendElement.py::populate_pubkey()

Added by Dennis Box 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
05/08/2019
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

Notice if an exception is thrown in populate_pubkey(), an item is deleted from a dictionary being iterated over. This throws an exception and does not follow the intent of the inline comments:

def populate_pubkey(self):
for globalid, globals_el in self.globals_dict.iteritems():
try:
globals_el['attrs']['PubKeyObj'] = pubCrypto.PubRSAKey(globals_el['attrs']['PubKeyValue'])
except: # if no valid key # if key needed, will handle the error later on
logSupport.log.warning("Factory Globals '%s': invalid RSA key" % globalid)
logSupport.log.exception("Factory Globals '%s': invalid RSA key" % globalid) # but remove it also from the dictionary
del self.globals_dict[globalid]

History

#1 Updated by Dennis Box 5 months ago

  • Assignee changed from Dennis Box to Marco Mambelli
  • Status changed from New to Feedback

#2 Updated by Marco Mambelli 5 months ago

  • Assignee changed from Marco Mambelli to Dennis Box
  • Status changed from Feedback to Resolved

There was a conflict. Solved and merged

#3 Updated by Marco Mambelli 4 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF