Necessary Maintenance #22523
Remove deprecated getIf() members from data proxy interface
0%
Description
proxy::CollectionProxyBase::getIf<T>() and proxy::CollectionProxyElement::getIf<T>() were provided to facilitate the implementation of generic code when it is not known whether the proxy object has a T data.
This type of coding is much easier when using C++17 if constexpr statement, which is now available in LArSoft.
As a consequence, the cumbersome getIf() is deprecated and marked for removal.
Not surprisingly, I could not find any code in LArSoft using it.
I will proceed myself to the removal according to the timeline that LArSoft will decide.
Associated revisions
History
#1 Updated by Kyle Knoepfel 7 months ago
- Status changed from New to Feedback
Although your proposal seems reasonable, we would like you to present your proposal at a LArSoft coordination meeting. Sound good?
Because the ALLOW_DEPRECATIONS flag has been removed, we request that you put future deprecations on a feature branch.
#2 Updated by Gianluca Petrillo 7 months ago
Sure.
Incidentally, I did verify that no code uses the deprecated feature beyond lardata.
Updated code to C++17.
The proxy object `getIf()` methods are now deprecated (issue #22523).