Project

General

Profile

Necessary Maintenance #22523

Remove deprecated getIf() members from data proxy interface

Added by Gianluca Petrillo 5 months ago. Updated 5 months ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
Data products
Target version:
-
Start date:
05/06/2019
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Duration:

Description

proxy::CollectionProxyBase::getIf<T>() and proxy::CollectionProxyElement::getIf<T>() were provided to facilitate the implementation of generic code when it is not known whether the proxy object has a T data.
This type of coding is much easier when using C++17 if constexpr statement, which is now available in LArSoft.
As a consequence, the cumbersome getIf() is deprecated and marked for removal.
Not surprisingly, I could not find any code in LArSoft using it.

I will proceed myself to the removal according to the timeline that LArSoft will decide.

Associated revisions

Revision 00c5fc55 (diff)
Added by Gianluca Petrillo 5 months ago

Updated code to C++17.

The proxy object `getIf()` methods are now deprecated (issue #22523).

History

#1 Updated by Kyle Knoepfel 5 months ago

  • Status changed from New to Feedback

Although your proposal seems reasonable, we would like you to present your proposal at a LArSoft coordination meeting. Sound good?

Because the ALLOW_DEPRECATIONS flag has been removed, we request that you put future deprecations on a feature branch.

#2 Updated by Gianluca Petrillo 5 months ago

Sure.
Incidentally, I did verify that no code uses the deprecated feature beyond lardata.



Also available in: Atom PDF