Project

General

Profile

Idea #2236

Add comments to reconfig

Added by Igor Sfiligoi almost 9 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Douglas Strain
Category:
-
Target version:
Start date:
12/07/2012
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Stakeholders:
Duration:

Description

Hi all.

Can we add the option to log a comment for every time the factory or the frontend is reconfigured?
With the reference to the prev and after xml files (we have those already).

It would be very useful to have a history when you have many admins handling the same system.

Igor


Subtasks

Bug #3163: Review #branch_master_2236 for masterClosedAnthony Tiradani

History

#1 Updated by Douglas Strain about 8 years ago

  • Assignee set to Douglas Strain

#2 Updated by Douglas Strain almost 8 years ago

  • Status changed from New to Feedback
  • Assignee changed from Douglas Strain to Parag Mhashilkar

I have addressed this. There are now two changes. There is an admin log in the factory directory. Currently, this just includes the reconfig comments, but could later include other things. The other is that reconfig now accepts a "-comment" option that will be put in the admin log.

Changes are in branch_v2plus_2236:
bf86d930964464197fb6b51fc97acc3b39f4015e
0ad69a7d086e7152ca4b2db3333409b9ca5ffdb6

Let me know if you have any comments in review.

#3 Updated by Igor Sfiligoi almost 8 years ago

The log message goes in the the .info file only, right?

While better than before, I don't think it is enough.
Those files are huge, and while it is likely not too hard to grep the relevant info out, it is still far from ideal in my view.

How about having just a dedicated "reconfig log"?

#4 Updated by Parag Mhashilkar almost 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

Looks ok to merge

#5 Updated by Douglas Strain almost 8 years ago

  • Target version set to v2_7_x

#6 Updated by Douglas Strain almost 8 years ago

This change is now merged.

To answer Igor's question, I have created a new log called the admin log. Right now, it only has the reconfig information. So, in essence this is a log just for reconfig information.

#7 Updated by Douglas Strain almost 8 years ago

  • Status changed from Feedback to Resolved

#8 Updated by Douglas Strain almost 8 years ago

One extra note here, this still needs to be implemented in master. It can't be cherry-picked since the logging implementation is so different. I will take care of this in the next week or so.

#9 Updated by Douglas Strain almost 8 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Douglas Strain to Parag Mhashilkar

Hi Parag, can you review this (or possibly assign to Tony to review)?

The master branch is significantly different with logging so I created a new branch for it:

branch_master_2236:
commit:0840daa8699a117d08efbb555ade583236237fcf
commit:17c8486acdbf1364e49b842d66a766fd99a480a3

Thanks!

#10 Updated by Parag Mhashilkar almost 8 years ago

  • Status changed from Feedback to Resolved
  • Target version changed from v2_7_x to 293

Created a ticket for master. Closing this ticket.

#11 Updated by Parag Mhashilkar almost 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

#12 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from 293 to v2_7

#13 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF