Project

General

Profile

Idea #22355

Add "Minimum" and "Maximum" to MetricMode, make it a flags enum

Added by Eric Flumerfelt 3 months ago. Updated 15 days ago.

Status:
Reviewed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/11/2019
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Duration:

Description

For some metrics, such as Shared Memory Available %, it may be desirable to have the minimum or maximum value of the metric during the interval available as a metric.

Thinking slightly more about this, we already have AccumulateAndRate, and one could easily want the AverageAndMinimum, AccumulateAndMaximum, and so on, so it might be best to make the MetricMode field settable via bitwise OR, i.e. MetricMode::Average | MetricMode::Minimum, MetricMode::Accumulate | MetricMode::Maximum, etc.

Thinking even more about this, it may be desirable to revise this functionality completely, such that each MetricPlugin instance can decide which Modes to report to its back-end. Most of the data needed to calculating each mode's value is already available to the MetricPlugin, and it would not be difficult to modify MetricData to ensure that the rest is available as well.


Related issues

Blocks artdaq - Feature #22615: Fragment latency trackingReviewed2019-05-21

History

#1 Updated by Eric Flumerfelt 2 months ago

  • Status changed from New to Resolved

Implementation on artdaq-utilities:feature/22355_MetricMode_BitwiseOr.

#2 Updated by Eric Flumerfelt 23 days ago

#3 Updated by Ron Rechenmacher 15 days ago

  • Status changed from Resolved to Reviewed

reviewed



Also available in: Atom PDF