Project

General

Profile

Necessary Maintenance #22259

mrb newProduct needs some updates

Added by Gianluca Petrillo almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
04/01/2019
Due date:
% Done:

100%

Estimated time:
Spent time:
Duration:

Description

The issues I remember encountering while running with mrb v3_00_12:

CMakeLists.txt (main)

  • either add ${CANVAS_ROOT_IO_DIR}/Modules to CMAKE_MODULE_PATH or remove include(ArtDictionary) line
    • I also got a build_dictionary: ROOT_VERSION is undefined error, fixed I believe by adding find_ups_root()
  • -std=c++11 should be removed and in general the compiler flags section updated

ups/product_deps

  • is gcc really needed here?
  • cet_build_tools version might be bumped up (but it's bound to become obsolete anyway, so it's not that important)

History

#1 Updated by Lynn Garren almost 2 years ago

  • Assignee set to Lynn Garren
  • Status changed from New to Assigned

Thank you for pointing this out. We will take a look.

#2 Updated by Lynn Garren over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Resolved

mrb newProduct has been brought up to date in mrb v3_02_00. This release is presently available on SciSoft and will be distributed with the upcoming larsoft release.

#3 Updated by Kyle Knoepfel over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF