Necessary Maintenance #22250
Remove DUNE and SBND specific code from larsim/PhotonPropagation/photpropservices.fcl and larsim/PhotonPropagation/opticalsimparameterisations.fcl
SBND and DUNE specific code was added to larsim. As these are just fcl parameters, they would be more appropriate inside the individual experiment's code, with either generic or dummy values used in the common code.
#5 Updated by Diego Gamez over 1 year ago
- % Done changed from 30 to 90
I have made the modifications in a new feature branch called "feature/dgg_opt_maintenance" (in larsoft v08_14_00). The modified packages are larsim, dunetpc and sbndcode. I simply moved the recently added (optical simulation related) DUNE and SBND specific code from photpropservices.fcl and opticalsimparameterisations.fcl to their "counterparts" photpropservices_dune.fcl, opticalsimparameterisations_dune.fcl, photpropservices_sbnd.fcl and opticalsimparameterisations_sbnd.fcl. These changes (only in .fcl filers) shouldn't change anything else related with simulation results.
I guess that the next step would be to merge this feature brach in develop. I have never done something like that (actually I am not sure if I can). So, could someone else make this last thing?