Project

General

Profile

Necessary Maintenance #22250

Remove DUNE and SBND specific code from larsim/PhotonPropagation/photpropservices.fcl and larsim/PhotonPropagation/opticalsimparameterisations.fcl

Added by Jason Stock 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
03/30/2019
Due date:
% Done:

100%

Estimated time:
Spent time:
Experiment:
-
Duration:

Description

SBND and DUNE specific code was added to larsim. As these are just fcl parameters, they would be more appropriate inside the individual experiment's code, with either generic or dummy values used in the common code.

History

#1 Updated by Christopher Green 5 months ago

  • Status changed from New to Feedback

This is a good idea. Do you need any assistance (access, say) to be able to do this?

#2 Updated by Jason Stock 5 months ago

I can't work on this right now. I don't have the free cycles. These are recent commits though. Perhaps we could ask to author (Diego) to do this?

#3 Updated by Lynn Garren 5 months ago

  • Assignee set to Diego Gamez
  • Status changed from Feedback to Assigned

Diego, are you able to make the requested change?

#4 Updated by Diego Gamez 5 months ago

  • % Done changed from 0 to 30

Yes, I will make the modifications.

#5 Updated by Diego Gamez 5 months ago

  • % Done changed from 30 to 90

I have made the modifications in a new feature branch called "feature/dgg_opt_maintenance" (in larsoft v08_14_00). The modified packages are larsim, dunetpc and sbndcode. I simply moved the recently added (optical simulation related) DUNE and SBND specific code from photpropservices.fcl and opticalsimparameterisations.fcl to their "counterparts" photpropservices_dune.fcl, opticalsimparameterisations_dune.fcl, photpropservices_sbnd.fcl and opticalsimparameterisations_sbnd.fcl. These changes (only in .fcl filers) shouldn't change anything else related with simulation results.
I guess that the next step would be to merge this feature brach in develop. I have never done something like that (actually I am not sure if I can). So, could someone else make this last thing?

#6 Updated by Lynn Garren 5 months ago

  • Assignee changed from Diego Gamez to Lynn Garren

Thank you Diego. We will test and merge the feature branch with an upcoming larsoft release.

#7 Updated by Lynn Garren 5 months ago

  • Status changed from Assigned to Resolved

This fix is now in larsoft v08_15_00.

#8 Updated by Lynn Garren 5 months ago

  • % Done changed from 90 to 100

#9 Updated by Lynn Garren 4 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF