Feature #22164
Upgrade jobsub code to use argparse instead of optparse
40%
Description
We want to use argparse to get jobsub ready to move to python 3. Some pointers for upgrading optparse to argparse are here:
https://docs.python.org/2.7/library/argparse.html#upgrading-optparse-code
With some playing around, it looks like opts, args = parser.parse_args() in optparse can become args, extras = parser.parse_known_args() pretty easily.
Related issues
History
#1 Updated by Shreyas Bhat 3 months ago
- Blocks Bug #21031: jobsub_submit allows more than one --group argument added
#2 Updated by Shreyas Bhat 2 months ago
- Status changed from New to Work in progress
#3 Updated by Shreyas Bhat 2 months ago
jobsub_fetchlog, jobsub_submit, and jobsub_q done and tested.
#4 Updated by Shreyas Bhat 2 months ago
jobsub_history done and tested.
#5 Updated by Shreyas Bhat about 2 months ago
- % Done changed from 0 to 20
jobsub_hold and jobsub_probe_url done and tested.
#6 Updated by Shreyas Bhat about 2 months ago
Rough outline of steps for each client module:
- imports (optparse, callbacks, version, etc)
- Usage line: %prog --> %(prog)s
- optparse --> argparse
- OptionParser --> ArgumentParser
- version_string: Comment out, add argument for Version_String
- opt_group --> client_options
- optparse.OptionGroup --> parser.add_argument_group; remove later parser.add_argument_group line
- add_option --> add_argument
- Change all types from strings to callables (like 'string' should become str)
- Change callbacks (action = callback --> action = actual callback class)
- Check that there's no "store_true" actions with metavars - argparse doesn't support that
- parser.parse_args --> parser.parse_known_args
- logSupport.dPrint.....: options --> vars(options)
#7 Updated by Shreyas Bhat about 1 month ago
The rest of the client code is updated, but my dev client/server isn't working as I expected. I assume it's something to do with the incommon/curl issues we'd seen. I'll first rebase the work here off of current master, since I'd need to anyway, and then troubleshoot my dev server.
#8 Updated by Shreyas Bhat 18 days ago
- % Done changed from 20 to 40
There was a bug in the jobsub_submit_dag code that I fixed. Ready to move onto the server.