Project

General

Profile

Idea #22068

Use recursive mutex in CommandableFragmentGenerator to improve code clarity

Added by Eric Flumerfelt about 2 years ago. Updated about 1 month ago.

Status:
Rejected
Priority:
Normal
Assignee:
Eric Flumerfelt
Category:
-
Target version:
-
Start date:
03/06/2019
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Duration:

Description

Kurt noticed that the dataBufferDepthFragments_ parameter is not updated at the same time as the dataBufferDepthBytes_ parameter, mostly because it is bound to dataBuffer_.size(). To improve code clarity, it would probably be best to replace dataBufferDepthFragments_ with a function that locks the dataBufferMutex_ recursively and returns dataBuffer_.size().

History

#1 Updated by Eric Flumerfelt over 1 year ago

I've implemented a change to feature/22068_CFG_UpdateDataBufferDepthFragmentsWithSize, where the DataBufferDepthFragments variable is updated at the same place as DataBufferDepthBytes. The original suggestion of using recursive_mutex was not easy to implement because the mutex in question was also being used to control condition_variables.

#2 Updated by Eric Flumerfelt over 1 year ago

  • Status changed from New to Resolved

#3 Updated by Eric Flumerfelt over 1 year ago

  • Assignee set to Eric Flumerfelt

#4 Updated by Eric Flumerfelt about 1 month ago

  • Status changed from Resolved to Rejected

This issue is obsoleted by the split between CommandableFragmentGenerator and FragmentBuffer.

Also available in: Atom PDF