Project

General

Profile

Support #22031

improve logging

Added by Dennis Box 7 months ago. Updated 7 months ago.

Status:
Accepted
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
03/01/2019
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

/var/lib/jobsub/debug.log is very verbose, and filled with information that is less than helpful

1)When a new request is processed in jobsub_api.py, report what the request is and from whom/where instead of the location of the jobsub.ini file, which never changes
2) make the verbosity level at least minimally configurable. Have a 'log_verbose' entry in jobsub.ini that can be set to true/false

History

#1 Updated by Dennis Box 7 months ago

  • Assignee changed from Dennis Box to Shreyas Bhat
  • Status changed from Assigned to Feedback

Please see branch 22031.

#2 Updated by Shreyas Bhat 7 months ago

This looks good. I had a couple of VERY small comments that showed up in the diff, though they aren't really related to this change:

1. auth.py, line 185: Is there any reason we're not using the builtin "splitlines()"? As in "lines = cmd_out.splitlines()"?
2. auth.py, lines 204-208. Are we sure it won't iterate? I just tried replacing the if/elif with the following, and it worked:

for elt in reversed(pfn):
    if elt in supported_roles:
        role = elt
        break

These are non-functional changes I'm proposing, so feel free to ignore them.

#3 Updated by Shreyas Bhat 7 months ago

  • Assignee changed from Shreyas Bhat to Dennis Box
  • Status changed from Feedback to Accepted


Also available in: Atom PDF