Project

General

Profile

Bug #22022

Convert per/frontend limits to integers before division

Added by Marco Mascheroni about 1 year ago. Updated almost 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
03/01/2019
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

It looks like if you set per frontend limits in the configuration, and you also set num_factories, then reconfigure does not work because it tries to divide int and string.

History

#1 Updated by Marco Mascheroni about 1 year ago

Changes are in v34/22022. Please, Lorena review.

#2 Updated by Marco Mascheroni about 1 year ago

  • Assignee changed from Marco Mascheroni to Lorena Lobato Pardavila

Changes are in v34/22022. Please, Lorena review.

#3 Updated by Marco Mascheroni about 1 year ago

  • Status changed from New to Feedback

#4 Updated by Lorena Lobato Pardavila about 1 year ago

  • Assignee changed from Lorena Lobato Pardavila to Marco Mascheroni
  • Status changed from Feedback to Accepted

Looks ok. You can merge

#5 Updated by Marco Mambelli about 1 year ago

  • Status changed from Accepted to Resolved

#6 Updated by Marco Mambelli about 1 year ago

  • Status changed from Resolved to Feedback

Just a note, is this OK w/ rounding?
Is the result float or integer division?

#7 Updated by Marco Mascheroni about 1 year ago

It is now, but you are right, it won't probably be with python 3!

#8 Updated by Marco Mascheroni about 1 year ago

E.g.:

>>> 3/2
1
>>> from __future__ import division
>>> 3/2
1.5

#9 Updated by Marco Mascheroni about 1 year ago

  • Status changed from Feedback to Resolved

Using // will fix it for python 3. Merged.

#10 Updated by Marco Mambelli almost 1 year ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF