Project

General

Profile

Support #21940

Bug #21898: Error preventing the Frontend fo match jobs

Unit tests for boolean and string values

Added by Lorena Lobato Pardavila 10 months ago. Updated 6 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
02/20/2019
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

Since we were experiments different issues with a boolean-string comparison, we need to more verifications.

Add the unit tests for testing both booleans and string values in the inputs. Also, check if the comparison is python3 proof


Related issues

Related to GlideinWMS - Support #21537: Double-check functions that deal with boolean ClassAd facing possible misleading behaviorClosed12/12/2018

History

#1 Updated by Lorena Lobato Pardavila 10 months ago

  • Related to Support #21537: Double-check functions that deal with boolean ClassAd facing possible misleading behavior added

#2 Updated by Marco Mambelli 10 months ago

  • Target version changed from v3_5 to v3_4_4

#3 Updated by Lorena Lobato Pardavila 9 months ago

  • Assignee changed from Dennis Box to Lorena Lobato Pardavila
  • Status changed from New to Work in progress

#4 Updated by Lorena Lobato Pardavila 9 months ago

  • Assignee changed from Lorena Lobato Pardavila to Dennis Box

Dennis and I have been spending a lot of time going through all the unit tests and trying to implement this. After having a meeting with Marco Mambelli where we've been discussing the workflow of the code (and having a better understanding of how dictionaries are dealt in GWMS :)), we have a better understanding about how to come up with a better solution.

Dennis is going to make the changes as he has more experience in UnitTests. I'll take the ticket back for feedback.

#5 Updated by Marco Mambelli 9 months ago

  • Target version changed from v3_4_4 to v3_5

#6 Updated by Marco Mambelli 8 months ago

  • Target version changed from v3_5 to v3_4_5

#7 Updated by Marco Mambelli 8 months ago

  • Target version changed from v3_4_5 to v3_5

#8 Updated by Dennis Box 8 months ago

  • Assignee changed from Dennis Box to Lorena Lobato Pardavila
  • Status changed from Work in progress to Feedback

see branch 35/21940 for review, can diff against master.
The boolean tests for glideinFrontendElement are in test_frontend_element.py. There are other changed unit tests but they are minor changes

#9 Updated by Lorena Lobato Pardavila 8 months ago

  • Assignee changed from Lorena Lobato Pardavila to Dennis Box

Feedback provided by slack.

Need to fix pylint errors (already fixed), unit tests errors and add documentation (suggestion: twiki) and docstrings.

#10 Updated by Dennis Box 6 months ago

  • Status changed from Feedback to Resolved

#11 Updated by Marco Mambelli 6 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF