Project

General

Profile

Feature #21901

It might be more natural to have TransferWrapper start reporting with the 1st event received rather than the 2nd

Added by Kurt Biery over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/14/2019
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

Currently, the TRACE messages from TransferWrapper when it receives events start with "the 2nd event received was of type <blah>". For a while, I was confused about where the first event got lost, but I found that it is just a zero/one initialization choice in TransferWrapper::receiveMessage().

I'm going to create a branch with the initialization of the "cntr" variable set to zero, as opposed to one. With this change, the first message that we'll see in the TRACE buffer from TransferWrapper will say '1st event'.

History

#1 Updated by Kurt Biery over 1 year ago

  • Status changed from Assigned to Resolved

The code change is committed on branch feature/21901_TransferWrapper_FirstReceivedMessage, which was branched from the head of develop.

#2 Updated by Eric Flumerfelt over 1 year ago

  • Status changed from Resolved to Reviewed
  • Co-Assignees Eric Flumerfelt added

Validated by code review.

Generally speaking, I'm not sure if TransferWrapper's use of static variables is entirely necessary, but for the sake of this one-line change, I can easily see from the code what the problem was and how the change resolves it.

#3 Updated by Eric Flumerfelt over 1 year ago

  • Target version set to artdaq v3_04_00
  • Status changed from Reviewed to Closed


Also available in: Atom PDF