Project

General

Profile

Bug #21804

If just_do_it.sh can't perform a transition, DAQInterface hangs

Added by John Freeman 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
01/30/2019
Due date:
% Done:

100%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

Specifically, what I'm finding is that in the scenario that during the configuration transition DAQInterface expects a FHiCL document but can't find it among the subconfigurations it's been given, DAQInterface will (as expected), announce the problem and set itself back into the Booted state. just_do_it.sh will then, as expected, print

DAQ failed to enter ready state; exiting /home/jcfree/artdaq-utilities-daqinterface/bin/just_do_it.sh

...however, even though DAQInterface was launched prior to the execution of just_do_it.sh (i.e., just_do_it.sh doesn't "own" DAQInterface, it requires DAQInterface to already be up), DAQInterface will no longer respond to XML-RPC calls. It would be nice if, should something go wrong with a transition in just_do_it.sh, even if just_do_it.sh exits out DAQinterface should still function properly.

History

#1 Updated by John Freeman 9 months ago

On further investigation, the hang was occurring whenever anything was typed into the shell DAQInterface was running in. Ron suggested I have DAQInterface ignore stdin by adding "<&-" to the DAQInterface alias. Change has been added to feature/issue21804_daqinterface_hang.

#2 Updated by John Freeman 9 months ago

  • Status changed from New to Resolved

I've tested DAQInterface on feature/issue21804_daqinterface_hang; typing input into the same shell that DAQInterface is running in now appears to have no effect.

#3 Updated by Eric Flumerfelt 9 months ago

  • Status changed from Resolved to Reviewed
  • Co-Assignees Eric Flumerfelt added

Reviewed code and made sure that things work properly with the new code.

#4 Updated by John Freeman 9 months ago

  • % Done changed from 0 to 100
  • Status changed from Reviewed to Closed

Using the fix Ron suggested appears to have solved the problem, as tested by myself and by Eric. Merged feature/issue21804_daqinterface_hang into develop and deleted the branch (feature/issue21804_daqinterface_hang, not develop).

#5 Updated by John Freeman 9 months ago

  • Status changed from Closed to Resolved

I'm un-closing this Issue since the protocol is to close an Issue when there's an official release. Having said that, I consider this Issue to be "Reviewed" (not "Resolved" as marked) but for whatever reason that option's not appearing in my drop-down list.



Also available in: Atom PDF