Project

General

Profile

Bug #21617

LArFFT service calling DetectorProperties service in constructor

Added by Tingjun Yang 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
01/02/2019
Due date:
% Done:

100%

Estimated time:
4.00 h
Spent time:
Occurs In:
Experiment:
DUNE
Co-Assignees:
Duration:

Description

Dear LarSoft experts,

Recently Owen implemented a ProtoDUNE specific DetectorPropertiesService. In function

DetectorPropertiesServiceProtoDUNEsp::preBeginRun(const art::Run& run)

he sets the ReadOutWindowSize based on run number.

There seems to be an issue with LArFFT service, which sets fSize based on ReadOutWindowSize in the constructor:

util::LArFFT::LArFFT(fhicl::ParameterSet const& pset, art::ActivityRegistry& /* reg */)
    : fSize    (pset.get< int        > ("FFTSize", 0))
    , fOption  (pset.get< std::string >("FFTOption"))
    , fFitBins (pset.get< int         >("FitBins"))
{

    // Default to the readout window size if the user didn't input
    // a specific size
    if(fSize <= 0)
      fSize = art::ServiceHandle<detinfo::DetectorPropertiesService>()->provider()->ReadOutWindowSize();
    std::cout<<"fSize = "<<fSize<<std::endl;
    InitializeFFT();
}

However, this seems to be called before DetectorPropertiesService updates the ReadOutWindowSize based on the run number so it used the default window size from a fcl parameter.

Any advice on this is appreciated.

Tingjun

Associated revisions

Revision b85aa981 (diff)
Added by Kyle Knoepfel 7 months ago

Resolve issue #21617: support run-dependent assignment of FFTSize.

History

#1 Updated by Kyle Knoepfel 8 months ago

  • Status changed from New to Feedback

There are various solutions to this problem. We will explore options and come up with a solution. How urgent is a fix for this?

#2 Updated by Tingjun Yang 8 months ago

Thanks Kyle. Since we are waiting for this to process ProtoDUNE special runs, we would like this to be resolved as soon as possible. Thanks.

#3 Updated by Kyle Knoepfel 8 months ago

  • Tracker changed from Support to Bug
  • Status changed from Feedback to Assigned
  • Assignee set to Kyle Knoepfel
  • Estimated time set to 4.00 h

#4 Updated by Kyle Knoepfel 7 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

#5 Updated by Kyle Knoepfel 7 months ago

This fix was included in last week's release (v08_03_00).

#6 Updated by Kyle Knoepfel 7 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF