Project

General

Profile

Bug #21572

Extra quote in CdfSettings.py causing ALL cdf jobs to fail

Added by Shreyas Bhat 8 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
12/21/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

This has actually been a bug since mid-January, and it was merged into 1.2.6_rc2 early February. But since it happens at the very end, and users got their output, they never noticed their jobs failing.

In a sample stderr file, https://jobsubdevgpvm01.fnal.gov:8443/jobsub/acctgroups/cdf/sandboxes/dbox/733.0@jobsubdevgpvm01.fnal.gov//testSAM.sh_20181217_135308_3295768_3_1_cluster.756.0.err/

You'll see something like this:

./condor_exec.exe: line 241: unexpected EOF while looking for matching `"'
./condor_exec.exe: line 244: syntax error: unexpected end of file

This is because on Line 240 of lib/groupsettings/CdfSettings.py, there's the line:

"""exiting with status $cpy_stat" """,

(notice the extra quote right after $cpy_stat).

Please take this out and merge into a 1.2.9 release candidate so we can test CDF jobs.

Note: I've made this high priority since it's low-hanging fruit that should be fixed anyhow.


Subtasks

Bug #21600: Review request [commit:4630e020474c39a13b4ad63a8bf78b1efbf9c543: echo "exiting" message - bugfix 21572]ClosedDennis Box


Related issues

Related to JobSub - Bug #21566: INC000001007918 jobsub dev release multiple issuesResolved2018-12-17

Associated revisions

Revision 10f78438 (diff)
Added by Dennis Box 8 months ago

fix for #21572 and #21615

History

#1 Updated by Shreyas Bhat 8 months ago

  • Related to Bug #21566: INC000001007918 jobsub dev release multiple issues added

#2 Updated by Shreyas Bhat 8 months ago

  • Assignee set to Shreyas Bhat

Assigning to myself to do the work. But Dennis will have to cut the release candidate.

#3 Updated by Shreyas Bhat 8 months ago

  • Status changed from New to Work in progress
  • % Done changed from 0 to 50

Made change, pushed to feature branch. Joe will test against fermicloud074.fnal.gov after the dCache downtime is done.

#4 Updated by Shreyas Bhat 8 months ago

Opened code review request to Dennis.

#5 Updated by Shreyas Bhat 8 months ago

  • Status changed from Work in progress to Resolved

Merged to master.

#6 Updated by Dennis Box 8 months ago

  • Target version changed from v1.2.9.rc_x to v1.2.9

#7 Updated by Shreyas Bhat 6 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF