Project

General

Profile

Bug #21417

BackTracker "HitToEveTrackIDEs" does not fill # electrons

Added by Tracy Usher about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
11/21/2018
Due date:
% Done:

0%

Estimated time:
Occurs In:
Experiment:
ICARUS, MicroBooNE
Co-Assignees:
Duration:

Description

See lines 182-200 of BackTracker.cc in LArSim. Note the field is left uninitialized and for debug builds this means one can get pretty much any number there.

Associated revisions

Revision 522b57dd (diff)
Added by Jason Stock about 1 year ago

Bugfix larsoft issue #21417

Revision 8deb05a7 (diff)
Added by Jason Stock about 1 year ago

Bugfix larsoft issue #21417

Revision aef2abef (diff)
Added by Jason Stock about 1 year ago

Bugfix larsoft issue #21417

Revision 037662f0 (diff)
Added by Jason Stock about 1 year ago

Bugfix larsoft issue #21417

History

#1 Updated by Lynn Garren about 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Jason Stock

Jason, would you take a look at this?

#2 Updated by Jason Stock about 1 year ago

Doing it now.

#3 Updated by Jason Stock about 1 year ago

Confirmed bug. The behavior is as described. EveTrackIDEs does not initialize the number of electrons, resulting in an undefined behaviour (any number could be spit out).
As a quick fix, I have made the trackIdToE map now use a pair<double, double> for it's value_type, making the first energy, and the second numElectrons. This isn't the most readable solution, but it is quick to implement and does correct the problem.

As to readability, this fix could be improved with either a clever typedef, or a very simple struct in the near future.

#4 Updated by Jason Stock about 1 year ago

Non breaking fix. Merged with develop. Thanks for pointing this out Tracy!

#5 Updated by Jason Stock about 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

#6 Updated by Jason Stock about 1 year ago

Note: There were two commits for this bug fix. Only one has been picked up by the issue tracker. The other (and very shortly after the first) was a small correction to writting the map. I just forgot to rebase before pushing.

#7 Updated by Lynn Garren about 1 year ago

  • % Done changed from 100 to 0

These should now be part of larsoft v07_12_00.

#8 Updated by Jason Stock 9 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF