Project

General

Profile

Bug #21394

Bug in Fiducial Volume Definition in Larsim

Added by Gray Putnam 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
11/17/2018
Due date:
% Done:

100%

Estimated time:
Occurs In:
Experiment:
SBND
Co-Assignees:
Duration:

Description

In the MCReoPart class in larsim, the fiducial volume is defined incorrectly for some experiments.

The fiducial volume is assumed to have: x_min = 0, z_min = 0, and y_min = - y_max. This is not true for (e.g.) SBND and ICARUS, and leads to MCTrack points being thrown out for monte carlo in those detectors.

Please let me know if this issue should be posted elsewhere -- I could not find an issue tracker in the larsim redmine.


Related issues

Related to LArSoft - Bug #13718: MCRecoPart uses non-portable coordinate systemResolved08/30/2016

History

#1 Updated by Gianluca Petrillo 11 months ago

As a reminder for the people involved, the MCReco algorithms are known1 to have been written in detector-specific way (MicroBooNE's, I believe).
It was suggested some time ago that, given the non-maintained state of those, they be moved to uboonecode.


1 Meaning, the issue has been already discussed in the past: this does not mean that LArSoft users (nor Greg) are expected to know.

#2 Updated by Kyle Knoepfel 11 months ago

  • Status changed from New to Feedback

We'd like to set up a meeting with you to discuss this issue.

#3 Updated by Gray Putnam 11 months ago

Kyle Knoepfel wrote:

We'd like to set up a meeting with you to discuss this issue.

With me? I'd be able to talk today or some time the week after Thanksgiving.

#4 Updated by Gianluca Petrillo 11 months ago

  • Related to Bug #13718: MCRecoPart uses non-portable coordinate system added

#5 Updated by Kyle Knoepfel 11 months ago

  • Status changed from Feedback to Assigned
  • Assignee set to Gray Putnam

#6 Updated by Kyle Knoepfel 10 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Resolved and included in LArSoft v07_13_00.



Also available in: Atom PDF