Project

General

Profile

Feature #21327

Report the target branch in subject of committing emails

Added by Gianluca Petrillo almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Other
Target version:
-
Start date:
11/07/2018
Due date:
% Done:

0%

Estimated time:
Spent time:
Experiment:
-
Co-Assignees:
Duration:

Description

As a premise, given the amount of commit e-mails flying around, I believe that the information that most helps people visually or automatically filter those e-mail should be the most prominent.

Currently a commit e-mail subject loks like:

[lardataobj] 01/01: add missing header

The vast majority of these e-mails pertains personal feature branches that I believe most of the people are not interested in.
In order to find out, though, one has to open the e-mail and look for the (not so apparent) branch name in its body.

Much better, and target of this request, would be to have the branch information directly in the subject, e.g.

[lardataobj:feature/escudero_PFParticleMetadataMigration] 01/01: add missing header

(or omitting feature/ for brevity: I hope nobody would push a feature/develop branch...).
Also in my experience this Lorena's branch name is quite longer than average, and I expect that normally it would take less space.


Related issues

Related to LArSoft - Feature #23133: Commit e-mail subject with branch informationClosed08/15/2019

History

#1 Updated by Kyle Knoepfel almost 2 years ago

  • Status changed from New to Under Discussion
  • Assignee set to Lynn Garren

We will talk with Marc about adjusting the subject line.

#2 Updated by Kyle Knoepfel almost 2 years ago

Lynn has talked with Marc Mengel, and this feature can be implemented, but it will require some effort.

#3 Updated by Lynn Garren almost 2 years ago

Correction, we know where to look but we do not yet know what options are available.

#4 Updated by Lynn Garren almost 2 years ago

email is controlled by /fnal/ups/db/fnal_git_notifier/current/scripts/fnal-git-notify-redmine

#5 Updated by Lynn Garren almost 2 years ago

The fnal-git-notify-redmine script uses git-multimail, which is controlled by settings in /cvs/projects/XXX/config on cvmfs.

As a test, I have just added a line to restrict the maximum number of lines to the larsim config.

[multimailhook]
    ....
    emailMaxLines = 100

#6 Updated by Lynn Garren over 1 year ago

  • Status changed from Under Discussion to Closed

We have looked carefully at the provided options. The header we have now is an informative as possible. Anything else would require expert editing of the python reporting script used by all redmine projects. We did edit the larreco and larsim config files to limit email to 500 lines. This issue is now closed.

#7 Updated by Lynn Garren about 1 year ago

  • Related to Feature #23133: Commit e-mail subject with branch information added


Also available in: Atom PDF