tag dunetpc v07_07_03
Please tag dunetpc v07_07_03.
#4 Updated by Alexander Himmel 8 months ago
Sorry -- we're going to need an 07_07_04. A bug in the photon simulation snuck in (my fault, an uninitialized variable) which wasn't caught by CI until after the tag was made. The fix is already committed, but we should probably confirm that the CI tests come back clean before tagging again.
#6 Updated by Tingjun Yang 8 months ago
David Adams wrote:
It will be v07_07_03_01. Let me know when you are ready. --da
Can we wait till tomorrow before tagging v07_07_03_01? Jake just pushed a new module to match TPC information with beam information and we want to test it. There is a chance for this to be included in the pick-up production. Thanks.
#12 Updated by David Adams 8 months ago
The c2 builds are failing with this error:
/scratch/workspace/dune-release-build/BUILDTYPE/debug/QUAL/c2/label1/swarm/label2/SLF6/temp/srcs/dunetpc/dune/Protodune/singlephase/RawDecoding/PDWaveform_module.cc:119:11: error: private field 'PDchanWaveIntPre' is not used [-Werror,-Wunused-private-field] TH1D* PDchanWaveIntPre; //Waveform integrations prebeam per channel ^ 1 error generated. Scanning dependencies of target dune_DAQTriggerSim_Service_TemplateTriggerService_service make: *** [dunetpc/dune/Protodune/singlephase/RawDecoding/CMakeFiles/PDWaveform_module.dir/PDWaveform_module.cc.o] Error 1 make: *** [dunetpc/dune/Protodune/singlephase/RawDecoding/CMakeFiles/PDWaveform_module.dir/all] Error 2
I add Tom to the list of watchers so he can fix this.
I will not make a new tag unless someone requests it. We do have c2 builds for v07_07_03.