Project

General

Profile

Task #21179

tag dunetpc v07_07_03

Added by Christoph Alt 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
10/18/2018
Due date:
% Done:

0%

Estimated time:
Duration:

Description

David,

Please tag dunetpc v07_07_03.

Christoph

History

#1 Updated by David Adams 8 months ago

  • Status changed from New to Work in progress

Test build is started.

#2 Updated by David Adams 8 months ago

Tag is made and builds are underway.

#3 Updated by David Adams 8 months ago

The gcc (e17) builds are installed. The clang builds will be installed after the mac builds complete.

#4 Updated by Alexander Himmel 8 months ago

Sorry -- we're going to need an 07_07_04. A bug in the photon simulation snuck in (my fault, an uninitialized variable) which wasn't caught by CI until after the tag was made. The fix is already committed, but we should probably confirm that the CI tests come back clean before tagging again.

-Alex

#5 Updated by David Adams 8 months ago

It will be v07_07_03_01. Let me know when you are ready. --da

#6 Updated by Tingjun Yang 8 months ago

David Adams wrote:

It will be v07_07_03_01. Let me know when you are ready. --da

Can we wait till tomorrow before tagging v07_07_03_01? Jake just pushed a new module to match TPC information with beam information and we want to test it. There is a chance for this to be included in the pick-up production. Thanks.

#7 Updated by Alexander Himmel 8 months ago

OK by me. Christoph -- can you confirm when the CI tests come back?

#8 Updated by Christoph Alt 8 months ago

CI test results are back to normal.

Christoph

#9 Updated by Tingjun Yang 8 months ago

Update: the beamline information module is almost ready. We will test it during the weekend and request a tag on Monday. This will be release candidate for keep-up processing.

#10 Updated by Tingjun Yang 8 months ago

Hi David, please tag v07_07_03_01 with the current develop. Thanks.

#11 Updated by David Adams 8 months ago

v07_07_03 is now installed for all platforms.

The tag for v07_07_03_01 is made and builds are underway.

#12 Updated by David Adams 8 months ago

The c2 builds are failing with this error:

/scratch/workspace/dune-release-build/BUILDTYPE/debug/QUAL/c2/label1/swarm/label2/SLF6/temp/srcs/dunetpc/dune/Protodune/singlephase/RawDecoding/PDWaveform_module.cc:119:11: error: private field 'PDchanWaveIntPre' is not used [-Werror,-Wunused-private-field]
    TH1D* PDchanWaveIntPre[288]; //Waveform integrations prebeam per channel
          ^
1 error generated.
Scanning dependencies of target dune_DAQTriggerSim_Service_TemplateTriggerService_service
make[2]: *** [dunetpc/dune/Protodune/singlephase/RawDecoding/CMakeFiles/PDWaveform_module.dir/PDWaveform_module.cc.o] Error 1
make[1]: *** [dunetpc/dune/Protodune/singlephase/RawDecoding/CMakeFiles/PDWaveform_module.dir/all] Error 2

I add Tom to the list of watchers so he can fix this.

I will not make a new tag unless someone requests it. We do have c2 builds for v07_07_03.

#13 Updated by David Adams 8 months ago

Tom, please see the error message in the preceding note.

#14 Updated by Alexander Himmel 8 months ago

This module is used by the photon detector team at CERN. I'm sure no one ever tried to build it on c2. Let me post this on Slack and see if someone can fix it.

#15 Updated by David Adams 8 months ago

Thanks Alex and sorry Tom--I saw decoding and blamed you without reading through to PDWaveform.

This should be easy to fix--just comment out this unused member.

#16 Updated by David Adams 8 months ago

  • Status changed from Work in progress to Closed

I am declaring victory here. Release v07_07_03 is installed on all platforms and release v07_07_03_01 is installed for e17 only.

I assume the c2 build problems will be reolved before we next attempt a release.

#17 Updated by Alexander Himmel 8 months ago

Fix is in now.



Also available in: Atom PDF