Feature #21105
metric_pset initialization in Cores
Status:
Resolved
Priority:
Low
Assignee:
Category:
Additional Functionality
Target version:
-
Start date:
10/10/2018
Due date:
% Done:
0%
Estimated time:
Experiment:
-
Co-Assignees:
Description
In DataLoggerCore, EventBuilderCore, and DispatcherCore, the metric_pset ParameterSet variable was default constructed then set to the "metrics" block of the configuration in a try/catch block. It is more efficient to simply use the optional ParameterSet.get<fhicl::ParameterSet> function to initialize this variable and avoid the exception entirely.
Implemented in artdaq/feature/DataLoggerCore_PotentiallyUninitializedMetricPsetFix
(I had originally thought that this could lead to metric_pset being uninitialized, but I remember now that since ParameterSet has a default consturctor, it won't be)