Project

General

Profile

Bug #21049

DAQInterface creates malformed FHiCL in metadata.fcl

Added by John Freeman about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
10/07/2018
Due date:
% Done:

100%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

If saving run info to a database on run start, DAQInterface will take the metadata.txt file from the run record and turn it into legal FHiCL. One of the features added just before the release of DAQInterface v3_03_00 was the addition of the beginning of a package's git commit comment on top of its git commit hash, e.g.

artdaq-core-demo commit/version: d7c93c94976855a3989f2b9c98f1ddff9e4c0fb9 "Store the distribution_type used to generate ToyFr..." 

instead of what would have happened previously, which was to save the commit only:
artdaq-core-demo commit:  d7c93c94976855a3989f2b9c98f1ddff9e4c0fb9

However, this addition breaks the logic whereby metadata.txt gets FHiCLized, and this should be fixed.

Associated revisions

Revision f3c4d5f1 (diff)
Added by John Freeman about 1 year ago

JCF: correctly FHiCL-ize the metadata.txt file now that it can save both a commit hash and a commit comment for a given git repo (see Issue #21049)

History

#1 Updated by John Freeman about 1 year ago

Fixed via commit f3c4d5f129729a934214528917ad1ca3ad7a4e13 on DAQInterface's develop branch. For the example line above, the FHiCLized version would look like this:

artdaq_core_demo_commit_or_version: "d7c93c94976855a3989f2b9c98f1ddff9e4c0fb9  Store the distribution_type used to generate ToyFr...  " 

#2 Updated by John Freeman about 1 year ago

  • % Done changed from 0 to 100

#3 Updated by John Freeman about 1 year ago

  • Status changed from New to Resolved


Also available in: Atom PDF