DAQInterface should be able to place requirements not just on a package's commit hash but also its version
Right now, DAQInterface typically has requirements on a git commit hash appearing in artdaq's repo. E.g., right now at the head of its develop branch, since DAQInterface calls the add_config_archive_entry which Kurt introduced back in July, it requires the following commit to appear in the git log of the artdaq repo:
commit b434f3b71dd5c87da68d6b13f040701ff610fee1 Author: Kurt Biery <firstname.lastname@example.org> Date: Sun Jul 15 16:02:21 2018 -0500 Added add_config_archive_entry and clear_config_archive methods to DataLoggerApp and EventBuilder app as part of restoring config information in art/ROOT files.
This is useful in that if DAQInterface called add_config_archive_entry while using an artdaq installation that didn't contain this commit, the artdaq process would instantly crash; this heads off the problem before it occurs. However, this check is only applied if artdaq is available in repo form. If artdaq is used as a ups product, the check is ignored. Kurt pointed out that it would be nice if DAQInterface could also apply a check if artdaq is used as a ups product.
#2 Updated by John Freeman about 2 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Satisfied by commits ba3c333b31c038d0601519171ca9b85b8f8e5a70 and efe2149526e4f1188d1a848bc20fad7bce1c8e00 on the develop branch. If an artdaq source repo's not available, rather than requiring a given git commit (or newer) we can require a given version (or newer).