Project

General

Profile

Support #20618

remove liblarreco_Deprecated

Added by Lynn Garren about 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/15/2018
Due date:
% Done:

100%

Estimated time:
Spent time:
Experiment:
-
Co-Assignees:
Duration:

Description

BezierTrack was moved to larreco/Deprecated, but not completely removed as a result of work done for issue #15446

We think the time has come to remove the Deprecated subdirectory entirely. Gianluca's detective work has found the places using BezierTrack.
  • `FeatureTracker` and `CornerFinderAlg` are something probably nobody will miss by now
  • `BezierCalorimetry`, `BezierTrackerAlgorithm`, `BezierTrackerModule` and event display hooks exist only because BezierTrack exist
  • the same is true for `BezierTracker` hooks in the various experiment `AnalysisTree` modules
  • BUT the code in `larana/OpticalDetector` might be still relevant
    • (`BeamFlashCompatibilityCheck_module.cc`, `TrackTimeAssoc_module.cc`)
    • both MicroBooNE and DUNE state that they are not using those OpticalDetector modules

It may be advisable to do this work in stages.

History

#1 Updated by Kyle Knoepfel about 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Lynn Garren
  • Priority changed from Normal to Low

#2 Updated by Lynn Garren 6 months ago

  • Priority changed from Low to Normal
  • Assignee changed from Lynn Garren to Kyle Knoepfel

Untangling everything will take a bit of work. Reassigning to Kyle.

#3 Updated by Kyle Knoepfel 5 months ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Resolved

This has been implemented as part of an effort to remove unused modules and services. The LArSoft packages and feature branches with the relevant commits are:

  • larana:feature/knoepfel_rm_bezier
  • lareventdisplay:feature/knoepfel_rm_bezier
  • larreco:feature/knoepfel_rm_bezier
  • lardata:feature/knoepfel_rm_unused_modules
  • larevt:feature/knoepfel_rm_unused_modules
  • larsim:feature/knoepfel_rm_unused_modules

Experiment packages and branches that accommodate the changes above are:

  • argoneutcode:feature/knoepfel_rm_bezier
  • dunetpc:feature/knoepfel_rm_bezier
  • icaruscode:feature/knoepfel_rm_bezier
  • ubana:feature/knoepfel_rm_bezier


Also available in: Atom PDF