Project

General

Profile

Necessary Maintenance #20568

Use of ValidHandle::failedToGet break use of ParticleInventory/BackTracker/PhotonBackTracker in gallery

Added by David Last 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
08/08/2018
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:
Experiment:
-
Duration:

Description

As this member will always return false if the art::ValidHandle can be created, then any check of what failedToGet returns is predetermined. The member does not exist in gallery::ValidHandle so having the check is problematic for gallery implementation of these Service Providers.

History

#1 Updated by Jason Stock 3 months ago

  • Target version set to v07_02_00

I've talked to David about this issue already. We understand it, it is definitely necessary maintenance for the BackTracking ServiceProviders to work in Gallery, and I will address it as soon as I wrap up my MCC11 work on the SNB runs.

#2 Updated by Kyle Knoepfel 3 months ago

  • Status changed from New to Assigned

#3 Updated by Jason Stock 3 months ago

  • Estimated time set to 1.00 h

I am just getting started on this now.

#4 Updated by Jason Stock 3 months ago

Should be fixed with commit e9842072b628bd4168e93b46bdfba788d841e2d6

Testing now.

#5 Updated by Jason Stock 3 months ago

  • Status changed from Assigned to Resolved

Resolved. I will leave it open for a few days.

#6 Updated by Lynn Garren 3 months ago

Thank you Jason. Please be aware that this fix has missed larsoft v07_02_00 and will be part of the next release.

#7 Updated by Jason Stock 3 months ago

Thanks for the update Lynn.

I had hoped to catch 7_02_00, but, mcc11 interfered. David has assured me this is not an urgent need (No need to request a special tag). We will wait for v7_03_00.

Cheers!

#8 Updated by Lynn Garren 3 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

Included in larsoft v07_03_00



Also available in: Atom PDF