Project

General

Profile

Bug #19830

Some pylint errors in unittests

Added by Marco Mambelli over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
04/28/2018
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

test_glideFactoryLogParser is using FETestCaseBase but not importing unittests/test_frontend.py
test_lib_xmlParse.py and test_classad have some uninitialized variables

Running the pylint test on the files may show others

History

#1 Updated by Dennis Box over 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Dennis Box to Marco Mambelli

changes in branch v3/19830
I fixed all of the pylint errors generated by CI except for factory/tools/configGUI.py . Is this tool supported or used? If so I will dig into it.

NB I am still confused by test_glideFactoryLogParser and test_classad I was unable to find any reference to them in git or the CI logs

#2 Updated by Marco Mambelli over 1 year ago

Dennis, as I told you I was confused about test_glideFactoryLogParser and test_classad, ignore that.

Thanks for fixing the files.
I'd ignore factory/tools/configGUI.py for now. I think it is no more used and there are a lot of problems. May be removed in the future.
For now add to the file (towards the top) the line:
  1. pylint: skip-file
    to skip it in the test and not cause the errors/warnings

In test_frontend_element.py I'd use a line disable: # @mock.patch defines these so disable pylint complaint E1120 (no-value-for-parameter)
create_glideinFrontendElement() # pylint: disable=no-value-for-parameter

In test_lib_xmlParse.py, test_domel2dict
you still use expected that seems not defined

After the fixes above it can be merged, thank you

#3 Updated by Marco Mambelli over 1 year ago

  • Assignee changed from Marco Mambelli to Dennis Box

#4 Updated by Dennis Box over 1 year ago

  • Status changed from Feedback to Resolved

#5 Updated by Marco Mambelli over 1 year ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF