Project

General

Profile

Bug #19621

Minor issue in performing bookkeeping on DataLogger config file

Added by Kurt Biery almost 2 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
John Freeman
Category:
-
Target version:
-
Start date:
04/10/2018
Due date:
% Done:

100%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

While testing config file includes (e.g. for artdaq-utilities-daqinterface/simple_test_config/config_includes), I noticed that DataLogger configuration files were being rejected by the DataLogger artdaq process. I traced this to a garbled RootOutput filename specification. This is shown on line 80 of the attached DataLogger_mu2edaq01.fnal.gov_5265.fcl file.

I've also attached the Aggregator1.fcl and standard_metrics_configs.fcl files that were used to generate this file.

I tracked the problem to what I believe is a minor bug in bookkeeping.py. On line 461, the full fhicl_used string was being searched for the RootOutput filename entry, rather than just the rootoutput_table. A modified copy of bookkeeping.py is attached for consideration.

DataLogger_mu2edaq01.fnal.gov_5265.fcl (27.7 KB) DataLogger_mu2edaq01.fnal.gov_5265.fcl See line 80 Kurt Biery, 04/10/2018 09:48 AM
Aggregator1.fcl (1.68 KB) Aggregator1.fcl Kurt Biery, 04/10/2018 09:48 AM
standard_metrics_configs.fcl (671 Bytes) standard_metrics_configs.fcl Kurt Biery, 04/10/2018 09:49 AM
bookkeeping.py (19.7 KB) bookkeeping.py See line 461 Kurt Biery, 04/10/2018 09:51 AM

Related issues

Related to artdaq Utilities - Bug #19655: FHiCL assignments that have names like ABC.rootDEF have extra "_dlN" substrings addedResolved04/11/2018

History

#1 Updated by Kurt Biery almost 2 years ago

John,
I have a candidate fix for this, as I mentioned in the description. Let me know if you would like me to commit the modified source file. I can do that to the develop branch or a feature branch.
Kurt

#2 Updated by Kurt Biery almost 2 years ago

  • Related to Bug #19655: FHiCL assignments that have names like ABC.rootDEF have extra "_dlN" substrings added added

#3 Updated by Kurt Biery almost 2 years ago

  • Status changed from New to Assigned
  • Assignee set to John Freeman

#4 Updated by John Freeman about 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Kurt fixed this with commit 6312d9892ec891a75b8e8384b0494362364edf6e, dated from April 11.

Also available in: Atom PDF