Project

General

Profile

Feature #19446

DetectorClocksStandard should initialise its trigger and beam times by itself

Added by Gianluca Petrillo almost 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Paul Russo
Category:
Library
Target version:
-
Start date:
03/20/2018
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

The current implementation of detinfo::DetectorClocksStandard requires the configuration of a default trigger time and a default beam gate opening time.
These times are recorded as "default" values but never used.
So far, it has been the duty of the art service (@detinfo::DetectorClocksStandardService`) to explicitly set the trigger and beam gate times to their default, which it does in a callback at every new event (and only if there is no raw trigger stored; otherwise, the time of that raw trigger is used instead of the default value).

My proposal is that the service provider on construction initialise the trigger and beam times with their configured default values, instead of initialising them to 0.0 as it currently happens.
This has almost no consequence when running in art (except if the service is accessed before the first run is processed), but it simplifies the initialisation of the service provider in environments, like gallery, which have no callback system.

History

#1 Updated by Gianluca Petrillo almost 3 years ago

  • Description updated (diff)

#2 Updated by Gianluca Petrillo almost 3 years ago

  • Description updated (diff)

#3 Updated by Katherine Lato almost 3 years ago

  • Assignee deleted (Gianluca Petrillo)

#4 Updated by Lynn Garren almost 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Katherine Lato

Katherine, this needs to be worked on soon.

#5 Updated by Katherine Lato almost 3 years ago

  • Assignee changed from Katherine Lato to Paul Russo

This could be a good one to work with Gianluca on.

#6 Updated by Katherine Lato over 2 years ago

  • Status changed from Assigned to Resolved

Paul says it's done.

#7 Updated by Paul Russo almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF