Project

General

Profile

Feature #19419

Move initialisation of CorsikaGen from constructor to beginJob()

Added by Gianluca Petrillo almost 2 years ago. Updated almost 2 years ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
Category:
Simulation
Target version:
-
Start date:
03/16/2018
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

To better support the use of art's --validate-config option, module and service constructors should limit their actions to the essence.
In this case, CorsikaGen appears to be copying flux files. This may probably be moved into beginJob() stage with no further consequence, so that it will not happen when --validate-config is used.

History

#1 Updated by Lynn Garren almost 2 years ago

  • Status changed from New to Accepted

LArSoft should have guidance about what belongs in a constructor.

Since the constructor calls ifdh and fetches named file(s), it may make sense to move it to beginJob, but this is not a general recommendation.

Also available in: Atom PDF