Project

General

Profile

Necessary Maintenance #19323

Port LArSoft code to use the association algorithms in canvas

Added by Gianluca Petrillo over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Library
Target version:
-
Start date:
03/07/2018
Due date:
% Done:

100%

Estimated time:
2.00 h
Spent time:
Experiment:
-
Duration:

Description

The algorithm util::for_each_associated_group() has been "moved" (in fact, copied) from LArSoft (lardata/Utilities/ForEachAssociatedGroup.h) into canvas (canvas:source:canvas/Persistency/Common/AssnsAlgorithms.h) with the new name art::for_each_group().

User code should be moved to use the art version.


Related issues

Blocked by LArSoft - Milestone #18796: Adopt art 2.10Closed01/25/2018

Associated revisions

Revision c20d7389 (diff)
Added by Gianluca Petrillo over 2 years ago

util::for_each_associated_group() deprecated.

Using `art::for_each_group()` now.
The old function is still present, deprecated.
This solves issue #19323.

History

#1 Updated by Gianluca Petrillo over 2 years ago

#2 Updated by Gianluca Petrillo over 2 years ago

  • Status changed from New to Assigned
  • Estimated time set to 2.00 h

#3 Updated by Gianluca Petrillo over 2 years ago

  • Description updated (diff)

#4 Updated by Gianluca Petrillo over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

The function util::for_each_associated_group() has been reimplemented to invoke the upstream canvas function. The LArSoft function itself is now formally deprecated and using it will trigger a compilation warning. The function is still available for backward compatibility, therefore this is not a breaking change.

The other functions in the header are still present, untouched.

The changes have been pushed into develop@ branch of %{color: crimson}lardata repository.

There is no evidence of these functions being used anywhere in the code base.

#5 Updated by Gianluca Petrillo over 2 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF