Project

General

Profile

Feature #18983

sam_metadata_dumper generates invalid metadata keys

Added by Marc Mengel over 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Start date:
02/13/2018
Due date:
% Done:

100%

Estimated time:
16.00 h
Spent time:
Scope:
Internal
Experiment:
-
SSI Package:
art
Duration:

Description

Every place we use sam_metadata_dumper we're having to filter its output because it generates keys and in some places values we cannot import.

For reference, the spec is here

Specifically:

  1. keys process_name, applicationVersion, applicationFamily, should be key {"application": {"version": x, "family":, y, "name": z}}
  2. first_event, last_event are yeilding lists of 3 integers when they should yeild the third value as a single integer
  3. Other tags that are not in the list from the SAM metadata spec, like 'file_format_era', 'file_format_version','run_type', need to be reworked as parameters, i.e they could be 'art.file_format_era' or 'art.file_format_version', in which case they could be imported directly if the appropriate parameter is added to SAM.

I think the best implementation for item 3 above, is to check against a dictionary of known keys from the specification, and if the item is not in there, prefix it with 'art.'.

History

#1 Updated by Kyle Knoepfel over 1 year ago

  • Tracker changed from Bug to Support
  • Status changed from New to Feedback

This will require a discussion since some clarifications are in order.

#2 Updated by Kyle Knoepfel about 1 year ago

  • Target version set to Vega

#3 Updated by Kyle Knoepfel about 1 year ago

  • Tracker changed from Support to Feature
  • Status changed from Feedback to Accepted

There have been no objections expressed from the stakeholders. We will implement the suggested proposal.

#4 Updated by Kyle Knoepfel about 1 year ago

  • Estimated time set to 16.00 h

#5 Updated by Kyle Knoepfel 11 months ago

  • Category set to Infrastructure
  • Status changed from Accepted to Resolved
  • Assignee set to Kyle Knoepfel
  • Target version changed from Vega to 3.01.00
  • % Done changed from 0 to 100
  • SSI Package art added

This feature has been implemented with commits:

Please note the following changes in how the SAM metadata is stored:

From To
first_event art.first_event
last_event art.last_event
applicationFamily application.family
applicationVersion application.version
file_format_era art.file_format_era
file_format_version art.file_format_version
process_name art.process_name
run_type art.run_type

In addition, the top-level fields first_event and last_event are also stored in single integer form, as specified by SAM. The art-specific first_event and last_event triplets are still stored but with the 'art.' prefix.

#6 Updated by Kyle Knoepfel 10 months ago

  • Target version changed from 3.01.00 to 3.02.00

#7 Updated by Kyle Knoepfel 6 months ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF