Necessary Maintenance #18199
Remove unmoveable MCParticle workaround
Experiment:
-
Description
A workaround is in place in LArG4::produce() (around larsim:source:larsim/LArG4/LArG4_module.cc#L534) to avoid memory usage spikes when transferring simb::MCParticle objects to the final data product.
This workaround should be removed after simb::MCParticle actually supports a real move (issue #12067).
It is enough to remove the iPartPair = particleList.erase(iPartPair); line and restore the range-for loop (instead of a while).
Related issues
Associated revisions
Removed workaround for unmoveable simb::MCParticle
This solves issue #18199.
History
#1 Updated by Gianluca Petrillo about 3 years ago
- Blocked by Bug #12067: Add move operations to simb::MCParticle added
#2 Updated by Katherine Lato about 3 years ago
- Status changed from New to Assigned
- Assignee set to Gianluca Petrillo
#3 Updated by Gianluca Petrillo almost 3 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Branch feature/gp_Issue18199 of larsim contains the fix.
The fix should be merged into the next release after v06_74_00, or in develop.
#4 Updated by Gianluca Petrillo almost 3 years ago
- Status changed from Resolved to Closed
Removed workaround for unmoveable simb::MCParticle
This solves issue #18199.