Project

General

Profile

Necessary Maintenance #18199

Remove unmoveable MCParticle workaround

Added by Gianluca Petrillo almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Simulation
Target version:
-
Start date:
11/10/2017
Due date:
% Done:

100%

Estimated time:
Spent time:
Experiment:
-
Duration:

Description

A workaround is in place in LArG4::produce() (around larsim:source:larsim/LArG4/LArG4_module.cc#L534) to avoid memory usage spikes when transferring simb::MCParticle objects to the final data product.
This workaround should be removed after simb::MCParticle actually supports a real move (issue #12067).
It is enough to remove the iPartPair = particleList.erase(iPartPair); line and restore the range-for loop (instead of a while).


Related issues

Blocked by NuTools - Bug #12067: Add move operations to simb::MCParticleClosed2016-03-25

Associated revisions

Revision 5c0f9f9d (diff)
Added by Gianluca Petrillo over 1 year ago

Removed workaround for unmoveable simb::MCParticle

This solves issue #18199.

Revision cf18334a (diff)
Added by Gianluca Petrillo over 1 year ago

Removed workaround for unmoveable simb::MCParticle

This solves issue #18199.

History

#1 Updated by Gianluca Petrillo almost 2 years ago

  • Blocked by Bug #12067: Add move operations to simb::MCParticle added

#2 Updated by Katherine Lato over 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo

#3 Updated by Gianluca Petrillo over 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Branch feature/gp_Issue18199 of larsim contains the fix.
The fix should be merged into the next release after v06_74_00, or in develop.

#4 Updated by Gianluca Petrillo over 1 year ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF